docs(vscode): list the four missing modules in the extension-host file map#246
Merged
Conversation
…e map The vscode.md architecture tree omitted workspace-chrome.ts, shell-selection.ts, agent-browser-host.ts, and iframe-proxy-host.ts — all present in vscode-ext/src/ and referenced elsewhere in the same spec (workspace-chrome as source of truth for workspaceTitle/workspaceBadge; the shell-selection section; closePoppedOutSessions in deactivate). Add them so the tree is an accurate file->responsibility map.
Deploying mouseterm with
|
| Latest commit: |
6701ec8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14dc00e3.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-vscode-spec-file-map.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the nightly code-quality survey.
The extension-host architecture tree in
docs/specs/vscode.mdlists 9 files butvscode-ext/src/currently holds four more that the tree omitted:workspace-chrome.ts— already cited later in the same spec as the source of truth forworkspaceTitle/workspaceBadge.shell-selection.ts— backs the spec's "Shell selection" section.agent-browser-host.ts— extension-host wiring + stream relay (closePoppedOutSessions, used indeactivate).iframe-proxy-host.ts— VS Code binding for the iframe transparent proxy.A reader using the tree as the file→responsibility map wouldn't find these modules. This adds them so the map matches the directory. Docs-only;
pnpm lint:specspasses.